Issue 2014

For this issue, the problem was that the publish link when it is generated, it did not have the hypertext protocol (https://) applied to the link. Pomax was concerned that Microsoft Edge did not like how the link was not generated with https://.

To solve this issue, I used the Firefox inspector to find how it is generated. I was able to find the javascript code used. Using the github repository for Thimble, I searched up different element and tag names used in the javascript.

Because there were so many files found, I was unable to locate the specific file that was used. Since the link is generated, I thought it was created from the server side. I was wrong. Gideonthomas replied in the github that it is actually generated from the client side. I am assuming this is the case since it requires the client's username to create a publish link. He was able to locate the exact file that was used to generate the href and text in html. 

From the page, I appended the word "html://" to the variable that held the original link. Once I refreshed the page, everything seemed fine. 

Below is the html page which is generated by the client side javascript codes: here it shows the href and the text to show up with hypertext protocol. 

The issue with my pull request is that once it is published with http://localhost, it does not work correctly. I think this may be due to the local dev factors which does not know how to deal with the protocol. 

Issue 1928

My 0.3 release is with issue-1928, which is posted on thimble repository, but it's actually under bracket. The issue is that URL hints does not do the right thing when spaces are in the path name.

This image shows what "hints" I am talking about. It displays the file names to make coding easier for web developers! According to the issue, if the path has a space in it, such as in file name, the Bracket URL encodes the path name, and adds "%20" wherever the spaces are found. According to David Humphrey, it was due to a javascript code encodeURI() function in bramble code. 

To fix the bug, I had an idea. It was to add hyphen(-) or underscore ( _ ), or just allow spacing in the path name. I suggested my idea and David was able to reply quickly. He asked me to just try removing the encodeURI() function from the code to see what happens. 

Once I removed the function, the hints came out perfectly. The path name did not have %20, when there were spaces in the path name. Surprisingly, it was quick bug to fix. I tested the hints with different characters as well and performed accordingly. I was suggested with other test by David, where I should see if I can publish the project. 

This is where everything went down hill for me! It looked perfect on preview even when I tested for different type of images (jpg, png, and gif). But when I try to publish them under localhost, nothing was working. All the images showed up as broken links. I was surprised this was happening and at the same time frustrated. Checked whether my repository was up-to-date as well, and it was. 

In the end, David suggested that he wants this issue closed. Mainly because he is rethinking the issue he filed originally and said that it may be correct to encode the path names that has spaces in it. 

Issue 1912

This issue is regarding UI design. The "sign in" and "Create account" link was changed to black for some reason in the recently updated master's repository. Flukeout just wanted me to change the colour of the text to the original which was white colour.

This was due to a recent changes to master's repo in github. Of course, this was unintentional!

To solve this issue, I used the Firefox inspector to find which html selector was being used. Then I was able to locate proper CSS page. Because I had experience with using CSS from previous bug that I worked on, I thought to myself, "oh this bug is gonna be super easy" - I was dead wrong.

It looked simple, but for someone who doesn't have good knowledge of HTML and how selectors work it was still a bit difficult. Or maybe I was thinking too simple. I thought all I need to do was to nest the selectors in one another but it did not work for me because according to Google, opacity cannot be overwritten.

Another thing I tried to do was change the opacity of navbar-anonymous selector, which encapsulated the entire top right text box, but since in thimble, the "sign in" and "create account" links are within the selector, they also changed to 0.65 opacity.

flukeout was able to give me hand with this one. He told me to look at the entire navbar, instead of just looking at the section - which is what I did. There, it was missing a "colour" in that element. With this, I was able to fix the issue and commit the changes.